Skip to content

fix: add type validation in DatetimeParser.parse() to handle list, dict, and None inputs#785

Closed
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin/1760018855-fix-datetime-parser-type-handling
Closed

fix: add type validation in DatetimeParser.parse() to handle list, dict, and None inputs#785
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin/1760018855-fix-datetime-parser-type-handling

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 9, 2025

fix: add type validation in DatetimeParser.parse() to handle list, dict, and None inputs

Summary

This PR fixes the TypeError: int() argument must be a string, a bytes-like object or a real number, not 'list' reported in oncall issue #9163 and similar issues affecting multiple connectors (Zendesk Support, Intercom, Stripe).

The error occurred when DatetimeParser.parse() was called with invalid input types (list, dict, None) instead of expected timestamp types (str, int, float). This commonly happens when concurrent cursor state converters attempt to parse partitioned state structures that contain nested arrays or dictionaries.

Changes:

  • Added explicit type validation at the start of parse() to reject None, list, and dict inputs with clear error messages
  • Added try-catch blocks around timestamp conversion operations for better error handling
  • Added comprehensive test coverage for all invalid input types (6 new test cases, all passing)

Review & Testing Checklist for Human

This is a defensive fix with moderate risk. Please verify:

  • Integration testing: Test with actual Zendesk Support connector using the state structures from the oncall issue to confirm the fix resolves the original TypeError scenarios
  • Error handling compatibility: Verify that changing error types (new TypeError/ValueError) doesn't break existing error handling code that may depend on specific error types
  • Root cause analysis: Consider whether this defensive approach aligns with team preferences vs. fixing the root cause in state converter logic that passes invalid types

Notes

  • All existing tests continue to pass (21/21), lint checks pass, mypy passes
  • This addresses the immediate TypeError but doesn't fix why invalid types are being passed to the parser in the first place
  • The fix covers list, dict, and None inputs as requested in the oncall issue comments
  • Related issues: airbytehq/oncall#9126, #9138, #8674, #8154, #8386, #7783, #7473

Link to Devin run: https://app.devin.ai/sessions/954333332fc24e6d8f5320322a82a2f2
Requested by: agarctfi

@devin-ai-integration
fix: add type validation in DatetimeParser.parse() to handle list, di…
72f8169 
…ct, and None inputs

This fix addresses TypeError issues reported in oncall issue #9163 and similar
issues where DatetimeParser.parse() is called with invalid input types (list,
dict, None) instead of expected timestamp types (str, int, float).

The error occurred when concurrent cursor state converters attempted to parse
partitioned state structures that contained lists or nested dictionaries as
cursor values. This affected multiple connectors including source-zendesk-support,
source-intercom, and source-stripe.

Changes:
- Add explicit type validation at the start of parse() to reject None, list, and dict inputs
- Provide clear error messages indicating the expected types vs actual type received
- Add try-catch blocks around timestamp conversions for better error handling
- Add comprehensive test coverage for all invalid input types

Fixes: airbytehq/oncall#9163
Related: airbytehq/oncall#9126, airbytehq/oncall#9138, airbytehq/oncall#8674,
         airbytehq/oncall#8154, airbytehq/oncall#8386, airbytehq/oncall#7783,
         airbytehq/oncall#7473
Co-Authored-By: unknown <>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

devin-ai-integration bot commented Oct 9, 2025

Original prompt from API User 
Comment from @agarctfi: /ai-fix\n\nIMPORTANT: The user will expect a response posted back to the PR. You should post exactly one comment back to the respective issue PR. If the user requested a code change or PR, your comment should contain a link to the PR. Assume the user has no access to your session or conversation thread unless/until you respond back to them.\n\nIssue #9163 by @octavia-squidington-iii: Source: Zendesk Support - ^^^^^^^^^
TypeError: int() argument must be a string, a bytes-like object or a real number, not 'list' (via Sentry)\n\nIssue URL: https://github.com/airbytehq/oncall/issues/9163\n\nPlease use playbook macro: !issue_fix

PLAYBOOK_md:
# AI Fix Playbook

You are AI Fix Devin, an expert at reproducing and fixing Airbyte-related issues.

## Context
You are working on the issue linked above in context. You will also need to pull issue comments for full context.

## Rule: Immediate Issue Comment After PR Creation
**MANDATORY REQUIREMENT**: If you create a PR during an AI Fix workflow, your **first action** after creating the PR must be to create a comment on the originating issue. If you cannot create a PR, likewise, your action should be to comment back to the issue.

## Your Task: Reproduce and Fix

1. **Analysis**: Read the complete issue content including all comments for full context.

2. **Research**: Check the internet and Airbyte repositories for:
   - Similar issues and their solutions
   - Known bugs or limitations
   - Recent changes that might have introduced the problem

3. **Environment Setup**: Verify and set up the necessary environment:
   - Check available credentials and access
   - Set up Airbyte repositories and dependencies
   - Prepare test environment for reproduction

4. **Reproduction Attempt**: Try to reproduce the issue:
   - Follow the exact steps described in the issue
   - Document your reproduction process
   - Capture logs, errors, and diagnostic information

5. **Root Cause Analysis**: If reproduction is succes... (1732 chars truncated...)

@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

devin-ai-integration bot commented Oct 9, 2025

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added bug Something isn't working security labels Oct 9, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1760018855-fix-datetime-parser-type-handling#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1760018855-fix-datetime-parser-type-handling

Helpful Resources

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment

📝 Edit this welcome message.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

PyTest Results (Fast)

3 787 tests  +6   3 775 ✅ +6   6m 18s ⏱️ -11s
    1 suites ±0      12 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 72f8169. ± Comparison against base commit b28c6e3.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

PyTest Results (Full)

3 790 tests  +6   3 778 ✅ +6   11m 12s ⏱️ +9s
    1 suites ±0      12 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 72f8169. ± Comparison against base commit b28c6e3.

@devin-ai-integration devin-ai-integration bot reopened this Oct 9, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1760018855-fix-datetime-parser-type-handling#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1760018855-fix-datetime-parser-type-handling

Helpful Resources

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment

📝 Edit this welcome message.

@aaronsteers Aaron ("AJ") Steers (aaronsteers) marked this pull request as draft October 9, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaronsteers @agarctfi